Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename bf-data to data-bf #12

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

1000hz
Copy link

@1000hz 1000hz commented Aug 8, 2019

Custom attributes must start with data- in order to conform to the HTML spec. This PR renames the bf-data attribute to data-bf in order to conform to the spec. This will be a breaking change.

Fixes #11

in order to be compliant with the HTML spec
@mjaggard
Copy link
Member

Sorry for the delay in responding @1000hz . We'd rather not make any breaking changes. We would be willing to accept a patch that allowed either data-bf or bf-data to be used as long as it doensn't break existing usage of this library.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bf-data is an invalid HTML attribute
2 participants