Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bf-data is an invalid HTML attribute #11

Open
1000hz opened this issue Aug 8, 2019 · 0 comments · May be fixed by #12
Open

bf-data is an invalid HTML attribute #11

1000hz opened this issue Aug 8, 2019 · 0 comments · May be fixed by #12

Comments

@1000hz
Copy link

1000hz commented Aug 8, 2019

Custom attributes must start with data- in order to conform to the HTML spec. Unfortunately, that means your markup is invalid when you put bf-data on your inputs, which has the potential to cause problems. I suggest changing this attribute to data-bf. This will be a breaking change.
@1000hz 1000hz linked a pull request Aug 8, 2019 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

rename bf-data to data-bf 1000hz/billforward-js
1 participant
@1000hz