Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Login with empty text of password. #118

Closed
smilesm2 opened this issue Nov 21, 2018 · 2 comments
Closed

Login with empty text of password. #118

smilesm2 opened this issue Nov 21, 2018 · 2 comments
Assignees
Labels

Comments

@smilesm2
Copy link

hi,
Thanks for this project. It really help me a lot.
But I found out that if I login with an empty text password, it will not be able to login and type account and password again until restart my browser(Chrome).
I think that is because Chrome remember basic-auth with my empty password.
So I add a if addition myAuth.pass !== "" on WebSSH2/app/server/util.js:12

var myAuth = Auth(req)
if (myAuth && myAuth.pass !== "") {
    req.session.username = myAuth.name

And now the input box of login will appear again just like inputing a wrong password!

@billchurch
Copy link
Owner

Okay, I see your problem here... I think I need to solve it a different way, because it's entirely possible that one could have a blank password... PermitEmptyPasswords is a setting in OpenSSH. Let me take a look at this.

And, it should re-prompt if you after a failure, if you have the allowreauth option set to true, which it currently does not. The problem is in my logic. Standby.

@billchurch billchurch self-assigned this Nov 21, 2018
@billchurch billchurch mentioned this issue Nov 21, 2018
@billchurch
Copy link
Owner

Okay, I need to spend more time on that to support a blank password, for now your suggestion will work fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants