Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allowreauth config option is not honored if initial auth is unsuccessful #117

Closed
billchurch opened this issue Nov 11, 2018 · 0 comments
Closed

allowreauth config option is not honored if initial auth is unsuccessful #117

billchurch opened this issue Nov 11, 2018 · 0 comments
Labels
bug

Comments

@billchurch
Copy link
Owner

When opening an issue, please include the follwing information:
Node Version: 6.9.1
Server OS Version: macos 10.13.6
WebSSH2 release version: 0.2.6
OS and Version of SSH server connecting to: macos 10.13.6
Browser Version and OS: Chrome 70 / macos 10.13.6

If allowreauth is set to false in config.json, reauth feature will still occur if the initial auth is unsuccessful. In this case, there should be no reauth attempt as the allowreauth feature is set to false.
@billchurch billchurch added the bug label Nov 11, 2018
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
fix reauth option, move files into /app, update dockerfile, update pa…
6dd7711 
…ckages

- `config.reauth` was not respected if initial auth presented was incorrect, regardless of `reauth` setting in `config.json` reauth would always be attempted. fixes billchurch#117
- **BREAKING** moved app files to /app, this may be a breaking change
- Updated dockerfile for new app path
- Updated app dependancies
  - xterm v3.8.0
    - https://github.com/xtermjs/xterm.js/releases/tag/3.8.0
  - basic-auth v2.0.1
    - https://github.com/jshttp/basic-auth/releases/tag/v2.0.1
  - express v4.16.4
    - https://github.com/expressjs/express/releases/tag/4.16.4
  - validator v10.9.0
    - https://github.com/chriso/validator.js/releases/tag/10.9.0
- Updated dev dependancies
  - snazzy v8.0.0
  - standard v12.0.1
  - uglifyjs-webpack-plugin v2.0.1
  - ajv v6.5.5
  - copy-webpack-plugin v4.6.0
  - css-loader v1.0.1
  - nodemon v1.18.6
  - postcss-discard-comments v4.0.1
  - snyk v1.108.2
  - url-loader v1.1.2
  - webpack v4.25.1
  - webpack-cli v3.1.2
hktalent pushed a commit to hktalent/webssh2 that referenced this issue Jun 3, 2022
@billchurch
fix reauth option, move files into /app, update dockerfile, update pa…
1fa4dfe 
…ckages

- `config.reauth` was not respected if initial auth presented was incorrect, regardless of `reauth` setting in `config.json` reauth would always be attempted. fixes billchurch#117
- **BREAKING** moved app files to /app, this may be a breaking change
- Updated dockerfile for new app path
- Updated app dependancies
  - xterm v3.8.0
    - https://github.com/xtermjs/xterm.js/releases/tag/3.8.0
  - basic-auth v2.0.1
    - https://github.com/jshttp/basic-auth/releases/tag/v2.0.1
  - express v4.16.4
    - https://github.com/expressjs/express/releases/tag/4.16.4
  - validator v10.9.0
    - https://github.com/chriso/validator.js/releases/tag/10.9.0
- Updated dev dependancies
  - snazzy v8.0.0
  - standard v12.0.1
  - uglifyjs-webpack-plugin v2.0.1
  - ajv v6.5.5
  - copy-webpack-plugin v4.6.0
  - css-loader v1.0.1
  - nodemon v1.18.6
  - postcss-discard-comments v4.0.1
  - snyk v1.108.2
  - url-loader v1.1.2
  - webpack v4.25.1
  - webpack-cli v3.1.2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@billchurch