Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump deadpool-postgres version #66

Closed
godofdream opened this issue Oct 19, 2020 · 8 comments
Closed

bump deadpool-postgres version #66

godofdream opened this issue Oct 19, 2020 · 8 comments
Labels
A-postgres Area: PostgreSQL support / deadpool-postgres S-duplicate Status: This issue or pull request already exists

Comments

@godofdream
Copy link

I added deadpool-postgres 0.5.6 which should depend on tokio-postgres=0.6.0
however the crate depends on tokio-postgres= "0.5.1"

maybe bumb deadpool-postgres to 0.6.0 to keep on paar with tokio-postgres and publish a new crate?

@bikeshedder
Copy link
Owner

This has already been done as of #65 and 227d4e4. I just haven't prepared a release on crates.io, yet. Originally I tried to support both tokio-postgres 0.5 and 0.6 but due to the tokio 0.3 changes I decided against this and make this a new MINOR release.

I'm still thinking about disabling most of the default features of the dependent crates as proposed by #60. Yet I'm not too happy about proxying all features. So I'm currently thinking about just disabling the default features and putting a big fat warning in the README that one needs to make sure to depend on the same version tokio-postgres version as deadpool-postgres if enabling extra features or it will result in an compile error.

That's something I wanted to figure out before pushing a new version to crates.io as this requires a new MINOR version just like bumping the tokio and tokio-postgres version.

My own project is currently blocked by hyperium/hyper#2302 so I'm not upgrading to tokio-postgres 0.6 and tokio 0.3 until this is fixed.

Please give the version in the repository a try. If that works for you I'll publish a new version on crates.io asap.

@bikeshedder bikeshedder added S-duplicate Status: This issue or pull request already exists A-postgres Area: PostgreSQL support / deadpool-postgres labels Oct 19, 2020
@godofdream
Copy link
Author

I switched to master and it compiles. However i have some issues with tokio 0.3 and will give feedback when it works.

@shiftrtech
Copy link

I stay tune, nice lib

@jbg
Copy link

jbg commented Nov 2, 2020

master is working well for me with tokio 0.3

@godofdream
Copy link
Author

Works for me, too.

@bikeshedder
Copy link
Owner

I'll release a new version on crates.io soon. It seams there are no issues running deadpool with tokio 0.3. 🎉

@bikeshedder
Copy link
Owner

I just released deadpool-postgres 0.6 on crates.io which adds support for tokio 0.3 and tokio-postgres 0.6:

https://crates.io/crates/deadpool-postgres/0.6.0

@jbg
Copy link

jbg commented Nov 5, 2020

I'm still thinking about disabling most of the default features of the dependent crates as proposed by #60. Yet I'm not too happy about proxying all features. So I'm currently thinking about just disabling the default features and putting a big fat warning in the README that one needs to make sure to depend on the same version tokio-postgres version as deadpool-postgres if enabling extra features or it will result in an compile error.

fwiw, I've always depended on deadpool-postgres in this way, so your suggestion seems like a good solution to me:

deadpool-postgres = { version = "0.6.0", default-features = false }
tokio-postgres = { version = "0.6.0", features = ["with-chrono-0_4", "with-serde_json-1", "with-uuid-0_8"] }

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-postgres Area: PostgreSQL support / deadpool-postgres S-duplicate Status: This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

4 participants