Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removal of warnings when running sudo bbb-record --rebuild <meeting-id> #15179

Closed
GuiLeme opened this issue Jun 14, 2022 · 6 comments
Closed

Comments

@GuiLeme
Copy link
Collaborator

GuiLeme commented Jun 14, 2022

Describe the bug
The following warning messages appear right after running the sudo bbb-record --rebuild <meeting-id>

$ sudo bbb-record --rebuild 97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300
Marking for rebuild 97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300
removed '/var/bigbluebutton/recording/status/sanity/97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300.done'
removed '/var/bigbluebutton/recording/status/processed/97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300-presentation.done'
removed '/var/bigbluebutton/recording/status/published/97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300-presentation.done'
Enqueing sanity worker with {:single_step=>false, :meeting_id=>"97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300"}
Pipelining commands on a Redis instance is deprecated and will be removed in Redis 5.0.0.

redis.pipelined do
  redis.get("key")
end

should be replaced by

redis.pipelined do |pipeline|
  pipeline.get("key")
end

(called from /var/lib/gems/2.7.0/gems/redis-namespace-1.8.2/lib/redis/namespace.rb:530:in `namespaced_block'}

To Reproduce
Steps to reproduce the behavior:

  1. Record a meeting;
  2. Get the meeting's internal id by running sudo bbb-record --tointernal <name-of-meeting>
  3. Run the command sudo bbb-record --rebuild <meeting-id>
  4. See the warning messages

Expected behavior
The only messages that should appear are the ones inside the debug logs:

$ sudo bbb-record --rebuild 97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300
Marking for rebuild 97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300
removed '/var/bigbluebutton/recording/status/sanity/97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300.done'
removed '/var/bigbluebutton/recording/status/processed/97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300-presentation.done'
removed '/var/bigbluebutton/recording/status/published/97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300-presentation.done'
Enqueing sanity worker with {:single_step=>false, :meeting_id=>"97e3c91af1503916102eb6dd5b930ea02e454044-1654893402300"}

Actual behavior
The warning messages appear along with the log ones.

Desktop (please complete the following information):

  • OS: Linux;
  • Version 2.4.x, 2.5.x, 2.6.x

Additional context
This is more of a solution suggestion: This error may be happening due to the gem redis-namespace, which now is on its version 1.8.2, released on march the 7th, as showed in the docs, while on the other hand, this issue has only been brought to their attention on march 9th, as described here, which already has a solution as we can see here. So if no other ideas come, I'd suggest we wait for this merging and releasing, and then we update, this dependency.

@ho30hero
Copy link

Hello
I have the same problem on my side.
BBB 2.5.1

@GuiLeme
Copy link
Collaborator Author

GuiLeme commented Jul 13, 2022

(Update) - Depending on this merge to be released, so that we can fix this issue: resque/resque#1806

@GuiLeme
Copy link
Collaborator Author

GuiLeme commented Aug 17, 2022

(Update) - The new version of redis-namespace has been released and we also updated the Gemfile for the version 1.9.0. But as we can see from this comment, apparently, we will have to wait a little bit longer for resque to release 2.3.0.

@hex-m
Copy link
Contributor

hex-m commented Sep 12, 2022

According to rubygems resque 2.4.0 is out by now.

@GuiLeme
Copy link
Collaborator Author

GuiLeme commented Nov 21, 2022

Hey guys, as @hex-m said before, version 2.4.0 of resque is out, I just updated my PR #15552 and it is working like a charm. So let's just wait until it is merged so we can close this issue.

Thanks for the reports guys, appreciate it.

@GuiLeme
Copy link
Collaborator Author

GuiLeme commented Dec 15, 2022

Hi guys! So, it seems that this issue is resolved with the merge of #15552 in v2.5.x-release and #16143 in v2.6.x-release, thank you all for your help and if any problems, keep me posted!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants