Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outdated instructions for wasm #627

Open
xJonathanLEI opened this issue Nov 15, 2022 · 0 comments
Open

Outdated instructions for wasm #627

xJonathanLEI opened this issue Nov 15, 2022 · 0 comments

Comments

@xJonathanLEI
Copy link

xJonathanLEI commented Nov 15, 2022

The --export flag has been removed, but the wasm guide still tells users to use it.

### Exporting results
Writing benchmark results to an in-memory filesystem in the browser is not very useful on its own. Luckily the results are easy to export and download as JSON:
```properties
hex --bench --export=base | download
```

The book needs to be updated with the latest instructions.

And... as a side question, how are we supposed to export wasm results now that the flag is gone (can't build cargo-criterion for wasm)? Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant