Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dependabot warnings for crossbeam-utils and regex #603

Closed
carlosbalbora opened this issue Jul 21, 2022 · 2 comments
Closed

Dependabot warnings for crossbeam-utils and regex #603

carlosbalbora opened this issue Jul 21, 2022 · 2 comments

Comments

@carlosbalbora
Copy link

I am using criterion.rs 0.3.6 that it uses crossbeam v0.8.6 (via rayon 1.5.1) and regex regex v1.5.4. It throws high level warnings:

@carlosbalbora
Copy link
Author

#604 <- my PR

@bheisler
Copy link
Owner

Thanks for the info and the pull request, but my policy is to not accept pull requests that only update dependency versions.

I considered making an exception but it seems that Cargo already happily pulls in and uses the new versions of those two dependencies even with the Criterion-rs specifying a dependency on the old version, so there doesn't seem to be any particular urgency as users can simply update their lockfiles and get a newer version of regex and rayon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants