fix: missing closing parenthesis in examples #585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
user_guide/advanced_configuration was missing closing parenthesis when calling bench_function
lemmih
approved these changes
Jul 2, 2022
|
Thanks lemmih for approving this pull request. |
Nope, everything checked out just fine. |
|
I just noticed the same error on https://bheisler.github.io/criterion.rs/book/index.html and was about to make this same pull request. Is there some automation that is broken that has prevented this from going live over the last half year? Even if it's tied to releases, it looks like 0.4.0 happened after this change was merged. |
|
I was wondering the same, do you have an insight @lemmih ? |
|
Not sure. Maybe the book has to be manually pushed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
user_guide/advanced_configuration was missing closing parenthesis when calling bench_function