Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.5 breaks MSRV using matches! macros #509

Closed
JohnTitor opened this issue Aug 6, 2021 · 1 comment
Closed

v0.3.5 breaks MSRV using matches! macros #509

JohnTitor opened this issue Aug 6, 2021 · 1 comment

Comments

@JohnTitor
Copy link

JohnTitor commented Aug 6, 2021

I'm not sure if this crate follows MSRV but #491 introduced matches! macros and v0.3.5 has bumped up MSRV (1.41).

@JohnTitor JohnTitor changed the title c0 v0.3.5 breaks MSRV using matches! macros Aug 6, 2021
@lemmih
Copy link
Collaborator

lemmih commented Aug 9, 2021

Hi @JohnTitor. As mentioned in the README, criterion supports the last three minor releases of rust. Support for older versions may be dropped without it being considered a breaking change. I'm open to discussing a policy change if this gets in the way of your workflow, though.

@lemmih lemmih closed this as completed Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants