Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Partly disable appveyor until performance can be improved. #492

Merged
merged 3 commits into from Jul 26, 2021

Conversation

lemmih
Copy link
Collaborator

@lemmih lemmih commented Jul 26, 2021

The Appveyor build requires 20-30 minutes to complete which limits feedback on PRs. With caching, it should take no more than 5 minutes to build and test all of criterion. Unfortunately, I'm not an expert at configuring Appveyor so we'll rely on GitHub Actions until I figure out the caching issue.

@lemmih
Copy link
Collaborator Author

lemmih commented Jul 26, 2021

Hm, renaming appveyor.yml didn't do the trick.

@lemmih
Copy link
Collaborator Author

lemmih commented Jul 26, 2021

Hm, it might be the cargo bench command that takes most of the build time.

@lemmih
Copy link
Collaborator Author

lemmih commented Jul 26, 2021

Building + Testing: ~5 minutes.
Benchmarking: 10 minutes.

There are two build configurations so the total time is roughly 30 minutes.

@lemmih lemmih changed the title Temporarily disable appveyor until performance can be improved. Partly disable appveyor until performance can be improved. Jul 26, 2021
@lemmih lemmih merged commit 7846322 into master Jul 26, 2021
@lemmih lemmih deleted the feature-disable-appveyor branch July 26, 2021 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant