Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IP address whitelisting #4

Closed
hexylena opened this issue Jul 29, 2014 · 5 comments
Closed

IP address whitelisting #4

hexylena opened this issue Jul 29, 2014 · 5 comments
Assignees
Labels
Milestone

Comments

@hexylena
Copy link
Collaborator

To secure containers (as best we can without access to galaxy's authentication), we need to provide IP address whitelisting for use in the containers. This is already started, but not complete due to docker issues.

There is a severe security vulnerability produced as a result of this lack of authentication, which we will consider in the following scenario:

Alice is happily using IPython Notebook from within Galaxy. Bob has turned evil and is portscanning galaxy instances looking for open IPython Notebooks (should be relatively trivial to do, not everyone runs python tornado webservers). Bob finds an open notebook, connects to it, and creates a new notebook in which he runs

%%bash
cat /import/conf.yaml

At this point Bob knows Alice's API key and it's game over for her. He has complete access to all the data she has access to.

@hexylena hexylena added this to the v0.2 milestone Jul 29, 2014
@hexylena hexylena self-assigned this Jul 29, 2014
@hexylena
Copy link
Collaborator Author

This should be ready as of d763689. More testing is needed before this is merged with master.

@hexylena
Copy link
Collaborator Author

Unfortunately this may not be possible:
iptables

See the docker changelog for the following quote from 0.8.1 release:

Drop NET_ADMIN capability for non-privileged containers. Unprivileged containers can't change their network configuration

This was found via moby/moby#4424

@hexylena hexylena changed the title IP address whitelisting not completed IP address whitelisting Jul 30, 2014
@hexylena
Copy link
Collaborator Author

Might be possible to hook into Galaxy's auth:
ipython/ipython#2770

@hexylena hexylena added bug and removed enhancement labels Jul 31, 2014
@hexylena
Copy link
Collaborator Author

@hexylena
Copy link
Collaborator Author

Closed in favour of #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant