New Check: V2 (*resource.StateChangeConf).WaitForState() Deprecation

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The (*github.com/hashicorp/terraform-plugin-sdk/v2/helper/resource.StateChangeConf).WaitForState() receiver method is deprecated in preference of the context-aware WaitForStateContext(). The new functionality is not available in version 1 of the Terraform Plugin SDK so this check should only flag version 2 usage of WaitForState.

New or Affected Checks(s)

• R###

Flagged Provider Code

conf := &resource.StateChangeConf{ /* ... */ }
conf.WaitForState()

Passing Provider Code

conf := &resource.StateChangeConf{ /* ... */ }
conf.WaitForStateContext(context.TODO()) // or plumbing the appropriate context through

References

• hashicorp/terraform-plugin-sdk@e5f5dae