New Check: Data Source schema.Resource Should Not Contain Importer Declaration

[bflad]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
• If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

It is not valid for data source schema.Resource to contain Importer declaration. Similar to R12 for CustomizeDiff in data sources.

New or Affected Checks(s)

• R###

Flagged Provider Code

&schema.Resource{
    Importer: /* ... */,
}

Passing Provider Code

&schema.Resource{
    // No Importer: /* ... */,
}

References

• rd/efs_access_point - add new resource hashicorp/terraform-provider-aws#11965
• Validate Data Sources Do Not Contain Importer Declarations hashicorp/terraform-plugin-sdk#460