Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Setup golangci-lint for all golang projects #689

Closed
Xuanwo opened this issue Jul 23, 2021 · 3 comments · Fixed by #690
Closed

Setup golangci-lint for all golang projects #689

Xuanwo opened this issue Jul 23, 2021 · 3 comments · Fixed by #690
Labels
enhancement New feature or request good first issue Issue template

Comments

@Xuanwo
Copy link
Contributor

Xuanwo commented Jul 23, 2021

As request in project-zot/zot#206 (comment)
@Xuanwo Xuanwo added enhancement New feature or request good first issue Issue template area/engineering labels Jul 23, 2021
@burntcarrot
Copy link
Member

I would like to take this issue but I apologize for taking up such a small issue again, because I'm new to go-storage and the codebase is enormous. I've been trying to understand each component since weeks, but I've been unable to do so, due to my lesser expertise in storage solutions. Hopefully I'll understand storage solutions in a better way one day. ♥

The only contributions I can currently make are CI setups and issues labeled with area/engineering. Apologies once again. 😓

@burntcarrot
Copy link
Member

On a side note, more docs for each service and its internal components would be preferred! 😀

@burntcarrot burntcarrot mentioned this issue Jul 23, 2021
Merged
@Xuanwo
Copy link
Contributor Author

Xuanwo commented Jul 24, 2021

On a side note, more docs for each service and its internal components would be preferred! grinning

It's indeed a problem. Can you start a new issue to describe which part you can't understand most in go-storage or go-service-*? We are happy to help!

@Xuanwo Xuanwo mentioned this issue Jul 26, 2021
Closed
@Xuanwo Xuanwo mentioned this issue Aug 2, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Issue template
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

CI: Add golangci-lint
2 participants
@Xuanwo @burntcarrot