From 4ef192b91a569d18c807d56be5791490529634ac Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Fran=C3=A7ois?= Date: Fri, 11 Nov 2022 23:46:45 +0000 Subject: [PATCH] Better bloom default settings (#6546) # Objective - Use better defaults for bloom ## Solution - Divide the intensity by 3. It's still noticeable - Change the mip level? (not sure about that change, it's from a discussion with @superdump) ### bloom example main: Screenshot 2022-11-11 at 01 09 26 this pr: Screenshot 2022-11-11 at 01 08 00 ### bistro scene main: Screenshot 2022-11-11 at 01 16 42 this pr: Screenshot 2022-11-11 at 01 15 12 --- crates/bevy_core_pipeline/src/bloom/mod.rs | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/crates/bevy_core_pipeline/src/bloom/mod.rs b/crates/bevy_core_pipeline/src/bloom/mod.rs index b710d8d8344c5..f94232ec156e0 100644 --- a/crates/bevy_core_pipeline/src/bloom/mod.rs +++ b/crates/bevy_core_pipeline/src/bloom/mod.rs @@ -149,7 +149,7 @@ pub struct BloomSettings { /// Scale used when upsampling (default: 1.0). pub scale: f32, - /// Intensity of the bloom effect (default: 1.0). + /// Intensity of the bloom effect (default: 0.3). pub intensity: f32, } @@ -159,7 +159,7 @@ impl Default for BloomSettings { threshold: 1.0, knee: 0.1, scale: 1.0, - intensity: 1.0, + intensity: 0.3, } } } @@ -805,5 +805,5 @@ fn queue_bloom_bind_groups( } fn calculate_mip_count(min_view: u32) -> u32 { - ((min_view as f32).log2().round() as u32 - 1).max(1) + ((min_view as f32).log2().round() as i32 - 3).max(1) as u32 }