feat: handle comment line for parse and stringify #213
Conversation
|
@NamPNQ looks good, I'll rebase and merge sometime after my current batch of work |
|
What are examples of symbol comments outside of parsed envfiles? I've never seem that stuff before and there isn't tests for stringifying such. |
|
@gonzaloriestra can you review and resolve this? |
|
I'd love to help, but unfortunately I don't have time for it right now... I created the other PR because we needed that in Shopify... Sorry! |
|
@gonzaloriestra no worries then, I'll probably get to it in April or May with my current backlog and availability. Would @Shopify be interested in sponsoring to get their support in all my project's readmes https://github.com/sponsors/balupton — thanks again for your PR! |
@balupton Hey, I'm a bit confused. Could you rephrase that for me? Or just give me an example |
|
@NamPNQ PR just needs tests and docs really |
This PR will handle comment line
For simply I don't write a complicated parser to handle it, I just use symbol for handle line with comment
The benefits of use it is didn't break our object when pass to
JSON.stringifyThis PR also fix tests and add test case for handle comment line correctly
Close #192