This repository was archived by the owner on Apr 11, 2024. It is now read-only.
Fix unkown nodejs version #123
Merged
+2
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Resolves #122 |
jdalton
reviewed
Mar 1, 2017
platform.js
Outdated
| @@ -772,7 +772,8 @@ | |||
| name = 'Node.js'; | |||
| arch = data.arch; | |||
| os = data.platform; | |||
| version = /[\d.]+/.exec(data.version)[0]; | |||
| var version = /[\d.]+/.exec(data.version) | |||
There was a problem hiding this comment.
Thanks @bilby91!
You don't have to use var as it's already defined above.
bilby91
force-pushed
the
fix-unkown-node-version
branch
from
0775bb9 to
ea5b123
Compare
|
@jdalton You are right! Fixed! |
jdalton
reviewed
Mar 1, 2017
platform.js
Outdated
| @@ -772,7 +772,8 @@ | |||
| name = 'Node.js'; | |||
| arch = data.arch; | |||
| os = data.platform; | |||
| version = /[\d.]+/.exec(data.version)[0]; | |||
| version = /[\d.]+/.exec(data.version) | |||
| version = (version && version.length > 0) ? version[0] : 'unknown'; | |||
There was a problem hiding this comment.
The check can be simplified. When performing an exec it will either be an array with at least 1 element or null so the check can be version ? version[0] : 'unknown'.
When running in react-native, the version property is no available, this fix will make the library not crash in those scenarios.
bilby91
force-pushed
the
fix-unkown-node-version
branch
from
ea5b123 to
f9f6564
Compare
|
Thank you! |
|
@jdalton Thank you for the quick interaction 👏🏻. Any plans for a new npm release ? |
|
There's a couple other fixes I'd like to land but there should be a new release within the week. |
|
@jdalton Great! Will be waiting for the release then. Thanks again ! |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running in react-native, the version property is no available, this
fix will make the library not crash in those scenarios.