New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[puppeteer-extra-plugin-block-resources] Error: Request is already handled! #156
Comments
Pull request: #157 |
Is this really solved? |
I did this manually and it solved it for me. Doesn't seem to be merged in with the master. |
What can i do then to avoid this?? 🌊 |
FYI I have a Puppeteer PR in to solve this puppeteer/puppeteer#6733 |
I hope they will accept it as soon as possible! |
@seth100 Try the package I just published https://www.npmjs.com/package/enchant-puppeteer |
thanks @benallfree, but trying to install that I get 404 |
@seth100 My fault, fixed in 0.0.2. Please install again: |
@benallfree it works great! No error no more! Thank you |
@benallfree thanks, yes I hope it will be integrated into |
Seems like the puppeteer maintainers are open to merge this in: puppeteer/puppeteer#6735 (comment) In case they end up not patching this upstream we can incorporate the changes in |
great news, I'll stay tuned for that! |
This is similar to issue #90 and #91 but is occured sporadically with this being the only plugin enabled and no other request interception exists in the code.
Unfortunately, I'm not allowed to post the code that's running but it's scraping a terribly designed web page with a few dozen iframes that continuously change as the code loops through them. The iframes also use the same resources.
I could be wrong, but I believe this error is occuring because the onRequest function is called multiple times for such "duplicate" resources even though they were handled once before. Regardless, I'm thinking that a solution would be to check if the request has been handled before request.continue() or request.abort() is called, as puppeteer does in the code below.
https://github.com/puppeteer/puppeteer/blob/c2651c2b5cc888ebd0ca6be87063d9f98b9eb59c/lib/NetworkManager.js#L456
The text was updated successfully, but these errors were encountered: