Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow failure of Python 3.8 #161

Merged
merged 3 commits into from Dec 7, 2019

Conversation

expobrain
Copy link
Contributor

No description provided.

Copy link
Owner

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! According to https://docs.travis-ci.com/user/languages/python/#python-versions, 3.8 is not available on 16.04 and 18.08 yet. I think we still need to use "3.8-dev".

@isidentical
Copy link
Contributor

I dont know if it is OK to ask this but an explanation would be really good to understand why allowing failures on 3.8. RC1 is out and soon stable version will be released too.

@expobrain
Copy link
Contributor Author

@isidentical it's absolutely ok to ask!
Python 3.8 is still a release candidate version, not suitable for production, so even if the possibility that this package will be broken under 3.8 it's still possible.
If we didn't allow failures on beta or release candidate version the in case of failures on those version the package will be seen as broken, which actually it's not for stable versions.
Once 3.8.0 is out as a stable version we'll stop allow failures on it.
Hope that this respond to your question; fi you have other questions feel free to ask!

@isidentical
Copy link
Contributor

.travis.yml Outdated Show resolved Hide resolved
@berkerpeksag berkerpeksag merged commit 7d714ac into berkerpeksag:master Dec 7, 2019
@berkerpeksag
Copy link
Owner

Thanks!

@expobrain expobrain deleted the allow_failures branch December 8, 2019 01:02
isidentical pushed a commit to isidentical/astor that referenced this pull request Dec 9, 2019
* Add 3.7 and 3.8 as stable versions
* Add new python/cpython master as 3.9-dev
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants