Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylecheck and Coverage to Tox #141

Merged
merged 6 commits into from
May 12, 2019
Merged

Stylecheck and Coverage to Tox #141

merged 6 commits into from
May 12, 2019

Conversation

isidentical
Copy link
Contributor

Stylecheck and Coverage to Tox
Fixes #38

berkerpeksag
berkerpeksag reviewed May 12, 2019
View reviewed changes
tox.ini Outdated Show resolved Hide resolved
tox.ini Outdated Show resolved Hide resolved
@isidentical
Copy link
Contributor Author

Now travis lints under python3.7 environment.

berkerpeksag
berkerpeksag reviewed May 12, 2019
View reviewed changes
Copy link
Owner

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add

[report]
show_missing = True

to .coveragerc as well?

I think you need to call coverage report after coverage run because it doesn't show coverage report at the moment.

Also, why did you change permission of tests/build_expressions.py?

@isidentical
Copy link
Contributor Author

isidentical commented May 12, 2019 •
edited

Can you add

Done

Also, why did you change permission of tests/build_expressions.py?

Sorry for inconvenience, i think i made that accidentally.

@berkerpeksag berkerpeksag merged commit 1f35741 into berkerpeksag:master May 12, 2019
@berkerpeksag
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add PEP 8 and coveragepy support to tox.ini
2 participants
@isidentical @berkerpeksag