Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fstring debugging support #139

Merged
merged 7 commits into from
May 12, 2019
Merged

Add fstring debugging support #139

merged 7 commits into from
May 12, 2019

Conversation

isidentical
Copy link
Contributor

Add fstring debugging support
Fixes #138

@isidentical
Copy link
Contributor Author

isidentical commented May 11, 2019 •
edited

Travis still using Python 3.8.0a3+ so failed builds are normal.

berkerpeksag
berkerpeksag reviewed May 11, 2019
View reviewed changes
Copy link
Owner

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, thank you! We also need to document this feature in docs/changelog.rst.

astor/code_gen.py Outdated Show resolved Hide resolved
tests/test_code_gen.py Outdated Show resolved Hide resolved
@isidentical
Copy link
Contributor Author

The 2.7 test is failed because of α & ω alpha and omega in tests.

berkerpeksag
berkerpeksag approved these changes May 12, 2019
View reviewed changes
Copy link
Owner

@berkerpeksag berkerpeksag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks! I'm gong to do a bit of cosmetic changes and merge today.

@berkerpeksag berkerpeksag merged commit 70b5924 into berkerpeksag:master May 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@berkerpeksag berkerpeksag berkerpeksag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Python3.8 f-string debugging
2 participants
@isidentical @berkerpeksag