Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't overwrite user base image #3329

Merged
merged 1 commit into from Dec 8, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Dec 8, 2022

Fixes #3325, a regression introduced by #3164

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner December 8, 2022 00:46
@aarnphm aarnphm requested review from jjmachan and removed request for a team December 8, 2022 00:46
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3329 (5642542) into main (970c5b2) will decrease coverage by 1.57%.
The diff coverage is 60.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3329      +/-   ##
==========================================
- Coverage   32.91%   31.33%   -1.58%     
==========================================
  Files         109      109              
  Lines        9917     9908       -9     
  Branches     1710     1628      -82     
==========================================
- Hits         3264     3105     -159     
- Misses       6424     6609     +185     
+ Partials      229      194      -35     
Impacted Files Coverage Δ
...toml/_internal/server/grpc/servicer/v1/__init__.py 0.00% <ø> (ø)
src/bentoml/_internal/container/generate.py 67.79% <50.00%> (+0.55%) ⬆️
src/bentoml/_internal/bento/build_config.py 50.65% <100.00%> (-4.49%) ⬇️
src/bentoml/_internal/container/__init__.py 44.79% <0.00%> (-32.30%) ⬇️
src/bentoml/_internal/utils/metrics.py 23.33% <0.00%> (-30.00%) ⬇️
src/bentoml/_internal/container/docker.py 34.48% <0.00%> (-27.59%) ⬇️
src/bentoml/_internal/container/base.py 46.72% <0.00%> (-16.83%) ⬇️
src/bentoml/_internal/io_descriptors/pandas.py 33.77% <0.00%> (-9.19%) ⬇️
src/bentoml/_internal/io_descriptors/base.py 79.54% <0.00%> (-9.10%) ⬇️
src/bentoml/_internal/bento/bento.py 73.61% <0.00%> (-6.25%) ⬇️
... and 17 more

@aarnphm aarnphm changed the title fix: regression introduced by #3164 fix: don't overwrite user base image Dec 8, 2022
@aarnphm aarnphm merged commit 2f5e247 into bentoml:main Dec 8, 2022
@aarnphm aarnphm deleted the fix/regression branch December 8, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: [bentoml-cli] build failed: Distro is required, got None instead.
2 participants