Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(grpc): adding service metadata #3278

Merged
merged 2 commits into from Dec 7, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Nov 25, 2022

What does this PR address?

Add a ServiceMetadata rpc that passing additional service metadata.

This is helpful for writing Python Client.

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

Before submitting:

@aarnphm aarnphm requested a review from a team as a code owner November 25, 2022 10:39
@aarnphm aarnphm requested review from sauyon and removed request for a team November 25, 2022 10:39
@codecov
Copy link

codecov bot commented Nov 25, 2022

Codecov Report

Merging #3278 (eb3df53) into main (eb3df53) will not change coverage.
The diff coverage is n/a.

❗ Current head eb3df53 differs from pull request most recent head 4eb7997. Consider uploading reports for the commit 4eb7997 to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3278   +/-   ##
=======================================
  Coverage   32.96%   32.96%           
=======================================
  Files         109      109           
  Lines        9900     9900           
  Branches     1704     1704           
=======================================
  Hits         3264     3264           
  Misses       6407     6407           
  Partials      229      229           

@aarnphm aarnphm force-pushed the feat/service-metadata branch 2 times, most recently from 6ea81ff to 2512f7a Compare November 26, 2022 03:09
@aarnphm aarnphm mentioned this pull request Nov 28, 2022
5 tasks
@aarnphm aarnphm force-pushed the feat/service-metadata branch 3 times, most recently from c65eec6 to 1466e0c Compare December 6, 2022 00:42
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm merged commit 970c5b2 into bentoml:main Dec 7, 2022
@aarnphm aarnphm deleted the feat/service-metadata branch December 7, 2022 08:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants