feat: make quickstart batchable #3172
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
requested review from
larme and
aarnphm
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3172 +/- ##
==========================================
- Coverage 21.71% 21.69% -0.03%
==========================================
Files 101 101
Lines 9721 9735 +14
Branches 1688 1691 +3
==========================================
+ Hits 2111 2112 +1
- Misses 7562 7575 +13
Partials 48 48
|
aarnphm
previously approved these changes
Nov 1, 2022
|
OO you need to run format and lint 😄 |
|
I'll add the hooks again eventually... |
|
still failed 😢 |
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
approved these changes
Nov 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes our quickstart example batchable by default.