fix(templates): ensure to use python3 and pip3 #3170
Merged
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
requested review from
jjmachan and
sauyon
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3170 +/- ##
=======================================
Coverage 21.71% 21.71%
=======================================
Files 101 101
Lines 9721 9721
Branches 1688 1688
=======================================
Hits 2111 2111
Misses 7562 7562
Partials 48 48
|
sauyon
approved these changes
Nov 1, 2022
aarnphm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensure our install.sh uses pip3 and python3
For distro such as amazonlinux, the docker container includes both python2 and python3.
python is often aliased with python2, hence this PR explicitly state the distinction.
Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com