Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support multipart upload for large bento and model #3044

Merged
merged 1 commit into from Sep 29, 2022

Conversation

yetone
Copy link
Member

@yetone yetone commented Sep 27, 2022

No description provided.

@yetone yetone requested a review from a team as a code owner September 27, 2022 17:54
@yetone yetone requested review from aarnphm and removed request for a team September 27, 2022 17:54
@yetone yetone requested review from bojiang and removed request for aarnphm September 27, 2022 17:56
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3044 (ad6dfbd) into main (a666072) will increase coverage by 6.47%.
The diff coverage is 26.11%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3044      +/-   ##
==========================================
+ Coverage   60.65%   67.13%   +6.47%     
==========================================
  Files         132      113      -19     
  Lines       11472    10925     -547     
  Branches     1913     1961      +48     
==========================================
+ Hits         6958     7334     +376     
+ Misses       4087     3151     -936     
- Partials      427      440      +13     
Impacted Files Coverage Δ
bentoml/_internal/yatai_client/__init__.py 19.83% <4.91%> (-4.23%) ⬇️
bentoml/_internal/yatai_rest_api_client/yatai.py 30.20% <25.00%> (-1.05%) ⬇️
bentoml/_internal/yatai_rest_api_client/schemas.py 93.86% <100.00%> (+0.33%) ⬆️
bentoml/_internal/frameworks/mlflow.py 54.62% <0.00%> (-28.47%) ⬇️
bentoml/_internal/utils/uri.py 68.42% <0.00%> (-10.53%) ⬇️
bentoml/_internal/utils/buildx.py 19.04% <0.00%> (-5.45%) ⬇️
bentoml/_internal/bento/build_dev_bentoml_whl.py 70.27% <0.00%> (-5.41%) ⬇️
bentoml/_internal/resource.py 72.12% <0.00%> (-2.43%) ⬇️
bentoml/_internal/service/inference_api.py 55.00% <0.00%> (-1.25%) ⬇️
bentoml/models.py 77.04% <0.00%> (ø)
... and 49 more

Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typing imports

bentoml_cli/models.py Outdated Show resolved Hide resolved
aarnphm
aarnphm previously approved these changes Sep 29, 2022
Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

aarnphm
aarnphm previously approved these changes Sep 29, 2022
@aarnphm aarnphm merged commit 926b613 into bentoml:main Sep 29, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants