Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: fix wrong name for example neural net #2959

Merged
merged 3 commits into from Aug 31, 2022
Merged

docs: fix wrong name for example neural net #2959

merged 3 commits into from Aug 31, 2022

Conversation

ssun-g
Copy link
Contributor

@ssun-g ssun-g commented Aug 31, 2022

What does this PR address?

Fixes #(issue)

Before submitting:

Who can help review?

Feel free to tag members/contributors who can help review your PR.

@ssun-g ssun-g requested a review from a team as a code owner August 31, 2022 08:20
@ssun-g ssun-g requested review from bojiang and removed request for a team August 31, 2022 08:20
@ssun-g ssun-g changed the title modify: get model's parameter to define optimizer modify: get model's parameter to define optimizer and model output Aug 31, 2022
@ssun-g ssun-g changed the title modify: get model's parameter to define optimizer and model output fix: get model's parameter to define optimizer and model output Aug 31, 2022
aarnphm
aarnphm approved these changes Aug 31, 2022
View reviewed changes
Copy link
Member

@aarnphm aarnphm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the spot

@aarnphm aarnphm changed the title fix: get model's parameter to define optimizer and model output docs: fix wrong name for example neural net Aug 31, 2022
@aarnphm aarnphm merged commit 37beaf8 into bentoml:main Aug 31, 2022
jiewpeng pushed a commit to jiewpeng/BentoML that referenced this pull request Sep 1, 2022
@ssun-g @jiewpeng
docs: fix wrong name for example neural net (bentoml#2959)
d7028e2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@bojiang bojiang Awaiting requested review from bojiang bojiang is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@ssun-g @aarnphm