docs: fix bentoml containerize command help message #2957
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
parano
changed the title
sauyon
reviewed
Aug 30, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Codecov Report
@@ Coverage Diff @@
## main #2957 +/- ##
==========================================
- Coverage 70.60% 69.71% -0.90%
==========================================
Files 104 104
Lines 9538 9538
==========================================
- Hits 6734 6649 -85
- Misses 2804 2889 +85
|
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
sauyon
reviewed
Aug 30, 2022
bentoml/bentos.py
Outdated
| f'To run your newly built Bento container, use: "docker run -it --rm -p 3000:3000 {docker_image_tag}"' | ||
| 'Successfully built docker image for "%s" with tags "%s"', | ||
| str(bento.tag), | ||
| docker_image_tag if not custom_tags else ",".join(docker_image_tag), |
There was a problem hiding this comment.
It seems to me like we should make this variable always an array.
There was a problem hiding this comment.
I remember we have this discussion before, let me do that.
ssheng
previously approved these changes
Aug 30, 2022
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
|
Er, these test failures look new, do you know what's going on? |
no clue, from 37beaf8 out of nowhere. |
jiewpeng
pushed a commit
to jiewpeng/BentoML
that referenced
this pull request
Sep 1, 2022
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update docstring to address #2956
This PR also fix a tiny messaging format when user did custom tag. I forgot to push the change for the message fixing multiple tags 馃槃