Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add uvicorn timeouts options #4682

Merged
merged 14 commits into from May 6, 2024

Conversation

gusghrlrl101
Copy link
Contributor

What does this PR address?

Fixes #4671

Before submitting:

@gusghrlrl101 gusghrlrl101 requested a review from a team as a code owner April 19, 2024 17:14
@gusghrlrl101 gusghrlrl101 requested review from aarnphm and removed request for a team April 19, 2024 17:14
@gusghrlrl101 gusghrlrl101 changed the title Uvicorn timeout option feat: add uvicorn timeouts options Apr 19, 2024
@parano parano requested a review from frostming April 29, 2024 14:08
Copy link
Contributor

@frostming frostming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tend to think timeouts shouldn't be a config of bento service, but options of bentoml serve and bentoml start only

@gusghrlrl101
Copy link
Contributor Author

@frostming

I deleted service's option as you said.
Please check agian.
Thank you.

@frostming frostming merged commit 3bf3385 into bentoml:main May 6, 2024
39 of 42 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: add http api server's uvicorn option
2 participants