Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: Allow to use HTTP other Method (GET, PUT, DELETE) to impl kserve predict protocol v2 #4590

Open
KimSoungRyoul opened this issue Mar 18, 2024 · 1 comment

Comments

@KimSoungRyoul
Copy link
Contributor

Feature request

https://github.com/kserve/kserve/blob/master/docs/predict-api/v2/required_api.md

svc = bentoml.Service(...)

@svc.api(
    route="predict/${PATH_VARIABLE}",
    method="GET", # <----
    
)
async def predict(path_variable: str):
     ....

Motivation

No response

Other

No response

@KimSoungRyoul
Copy link
Contributor Author

KimSoungRyoul commented Apr 8, 2024

hi @frostming

I think that support other Method (as least GET) not only POST in BentoML is useful to extend BentoML

Can you include this issue in bentoml team's maelstrom or
if you're positive about this minor feature, I can make the PR

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant