Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(container): podman health result string parsing #3330

Merged
merged 1 commit into from Dec 8, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Dec 8, 2022

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

@aarnphm aarnphm requested a review from a team as a code owner December 8, 2022 00:57
@aarnphm aarnphm requested review from parano and removed request for a team December 8, 2022 00:57
@codecov
Copy link

codecov bot commented Dec 8, 2022

Codecov Report

Merging #3330 (c516807) into main (2f5e247) will decrease coverage by 0.00%.
The diff coverage is 0.00%.

❗ Current head c516807 differs from pull request most recent head f79b00b. Consider uploading reports for the commit f79b00b to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3330      +/-   ##
==========================================
- Coverage   31.33%   31.33%   -0.01%     
==========================================
  Files         109      109              
  Lines        9908     9907       -1     
  Branches     1628     1628              
==========================================
- Hits         3105     3104       -1     
  Misses       6609     6609              
  Partials      194      194              
Impacted Files Coverage Δ
src/bentoml/_internal/container/podman.py 21.62% <0.00%> (ø)
...toml/_internal/server/grpc/servicer/v1/__init__.py 0.00% <ø> (ø)
src/bentoml/_internal/container/generate.py 67.24% <0.00%> (-0.56%) ⬇️

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@aarnphm aarnphm changed the title fix: podman health fix(container): podman health result string parsing Dec 8, 2022
@aarnphm aarnphm merged commit a2a4c5e into bentoml:main Dec 8, 2022
@aarnphm aarnphm deleted the fix/podman-command branch December 8, 2022 04:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants