fix: io descriptor backward compatibility #3327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
force-pushed
the
client-backwards-fix
branch
from
772f2cf
to
f2abbdd
Compare
Codecov Report
@@ Coverage Diff @@
## main #3327 +/- ##
=======================================
Coverage 32.91% 32.91%
=======================================
Files 109 109
Lines 9918 9918
Branches 1710 1710
=======================================
Hits 3265 3265
Misses 6424 6424
Partials 229 229 |
sauyon
force-pushed
the
client-backwards-fix
branch
from
f2abbdd
to
54d2319
Compare
Previously, when `to_spec` was not implemented, the entire Bento server would just raise. Now, it simply returns null when getting unknown IO descriptor specs, and the client is made to error in that case.
sauyon
force-pushed
the
client-backwards-fix
branch
from
54d2319
to
c5e3049
Compare
aarnphm
approved these changes
Dec 8, 2022
aarnphm
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts a few backwards-incompatible changes to the IO descriptor specification for custom IO descriptors, as well as adding a test containing a custom IO descriptor intended to test for this in the future.