Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(runner): remote run_method with kwargs #3326

Merged
merged 1 commit into from Dec 8, 2022

Conversation

larme
Copy link
Member

@larme larme commented Dec 7, 2022

What does this PR address?

Fixes the problem that anyio.from_thread.run does not support kwargs

Before submitting:

@larme larme requested a review from a team as a code owner December 7, 2022 23:07
@larme larme requested review from ssheng and removed request for a team December 7, 2022 23:07
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3326 (1408cd9) into main (7a8ee5f) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3326   +/-   ##
=======================================
  Coverage   32.91%   32.91%           
=======================================
  Files         109      109           
  Lines        9917     9917           
  Branches     1710     1710           
=======================================
  Hits         3264     3264           
  Misses       6424     6424           
  Partials      229      229           
Impacted Files Coverage Δ
...c/bentoml/_internal/runner/runner_handle/remote.py 0.00% <ø> (ø)

@aarnphm aarnphm merged commit e498178 into bentoml:main Dec 8, 2022
@ssheng
Copy link
Collaborator

ssheng commented Dec 8, 2022

Let's make sure the e2e test cover this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants