chore: provides shim for bentoctl #3322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
requested review from
jjmachan and
ssheng
and removed request for
a team
Codecov Report
@@ Coverage Diff @@
## main #3322 +/- ##
==========================================
- Coverage 33.74% 33.64% -0.11%
==========================================
Files 108 110 +2
Lines 9853 9886 +33
Branches 1697 1699 +2
==========================================
+ Hits 3325 3326 +1
- Misses 6299 6331 +32
Partials 229 229
|
ssheng
previously approved these changes
Dec 7, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
jjmachan
approved these changes
Dec 7, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
provide backward shim for bentoctl until it migrates to public API
I have tested with sagemaker. with and without conda.
Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com