Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove assertion for dtype #3320

Merged
merged 4 commits into from Dec 7, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Dec 7, 2022

remove assertion check for _dtype, as pd.read_json and read_csv does accept dtype with bool for auto infer types

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner December 7, 2022 00:00
@aarnphm aarnphm requested review from bojiang and removed request for a team December 7, 2022 00:00
@codecov
Copy link

codecov bot commented Dec 7, 2022

Codecov Report

Merging #3320 (ce205eb) into main (687c3e0) will not change coverage.
The diff coverage is 0.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3320   +/-   ##
=======================================
  Coverage   33.74%   33.74%           
=======================================
  Files         108      108           
  Lines        9853     9853           
  Branches     1697     1697           
=======================================
  Hits         3325     3325           
  Misses       6299     6299           
  Partials      229      229           
Impacted Files Coverage Δ
src/bentoml/_internal/io_descriptors/pandas.py 42.95% <0.00%> (ø)

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from sauyon December 7, 2022 00:45
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also deprecates passing non-dataframe input to DataFrame.from_sample.

@aarnphm aarnphm merged commit c662b2f into bentoml:main Dec 7, 2022
@aarnphm aarnphm deleted the fix/from-sample-pandas branch December 7, 2022 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: PandasDataFrame.from_sample fails internal assertion in from_http_request
2 participants