Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(monitor): disable validate for Formatter #3317

Merged
merged 1 commit into from Dec 6, 2022

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Dec 6, 2022

No description provided.

@bojiang bojiang requested a review from a team as a code owner December 6, 2022 03:03
@bojiang bojiang requested review from larme and removed request for a team December 6, 2022 03:03
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #3317 (f2297be) into main (d4bb5cb) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3317   +/-   ##
=======================================
  Coverage   33.74%   33.74%           
=======================================
  Files         108      108           
  Lines        9849     9849           
  Branches     1696     1696           
=======================================
  Hits         3324     3324           
  Misses       6296     6296           
  Partials      229      229           
Impacted Files Coverage Δ
src/bentoml/_internal/monitoring/default.py 0.00% <ø> (ø)

@bojiang bojiang requested review from aarnphm and removed request for larme December 6, 2022 03:08
@aarnphm
Copy link
Member

aarnphm commented Dec 6, 2022

I'm ok with this hack for now. Eventually, we will want to validate the config.

@aarnphm aarnphm changed the title fix(monitor): disable validate for format fix(monitor): disable validate for Formatter Dec 6, 2022
@aarnphm aarnphm merged commit 210071a into bentoml:main Dec 6, 2022
@bojiang bojiang deleted the fix-monitor branch December 6, 2022 05:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants