New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: grpc servicer implementation per version #3316
Merged
aarnphm
merged 5 commits into
bentoml:main
from
aarnphm:chore/refactor-servicer-implementation
Dec 7, 2022
Merged
feat: grpc servicer implementation per version #3316
aarnphm
merged 5 commits into
bentoml:main
from
aarnphm:chore/refactor-servicer-implementation
Dec 7, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aarnphm
requested review from
ssheng and
sauyon
and removed request for
a team
December 6, 2022 01:43
Codecov Report
@@ Coverage Diff @@
## main #3316 +/- ##
==========================================
- Coverage 33.74% 0.00% -33.75%
==========================================
Files 108 108
Lines 9849 9859 +10
Branches 1696 0 -1696
==========================================
- Hits 3324 0 -3324
- Misses 6296 9859 +3563
+ Partials 229 0 -229
|
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
chore/refactor-servicer-implementation
branch
from
December 6, 2022 05:09
606ca6b
to
dde673a
Compare
sauyon
reviewed
Dec 6, 2022
src/bentoml/_internal/server/grpc/servicer/v1alpha1/__init__.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
sauyon
reviewed
Dec 7, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
sauyon
approved these changes
Dec 7, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com