Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: grpc servicer implementation per version #3316

Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Dec 6, 2022

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

@aarnphm aarnphm requested a review from a team as a code owner December 6, 2022 01:43
@aarnphm aarnphm requested review from ssheng and sauyon and removed request for a team December 6, 2022 01:43
@codecov
Copy link

codecov bot commented Dec 6, 2022

Codecov Report

Merging #3316 (eb0af7e) into main (d4bb5cb) will decrease coverage by 33.74%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3316       +/-   ##
==========================================
- Coverage   33.74%   0.00%   -33.75%     
==========================================
  Files         108     108               
  Lines        9849    9859       +10     
  Branches     1696       0     -1696     
==========================================
- Hits         3324       0     -3324     
- Misses       6296    9859     +3563     
+ Partials      229       0      -229     
Impacted Files Coverage Δ
...c/bentoml/_internal/bento/build_dev_bentoml_whl.py 0.00% <0.00%> (-68.58%) ⬇️
src/bentoml/_internal/io_descriptors/base.py 0.00% <0.00%> (-88.64%) ⬇️
src/bentoml/_internal/io_descriptors/json.py 0.00% <0.00%> (-38.66%) ⬇️
...toml/_internal/server/grpc/servicer/v1/__init__.py 0.00% <0.00%> (ø)
...internal/server/grpc/servicer/v1alpha1/__init__.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/grpc_app.py 0.00% <0.00%> (ø)
src/bentoml/_internal/service/service.py 0.00% <0.00%> (-72.50%) ⬇️
src/bentoml/grpc/utils/__init__.py 0.00% <0.00%> (-46.97%) ⬇️
src/bentoml/grpc/utils/_import_hook.py 0.00% <0.00%> (-100.00%) ⬇️
... and 68 more

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm force-pushed the chore/refactor-servicer-implementation branch from 606ca6b to dde673a Compare December 6, 2022 05:09
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@aarnphm aarnphm merged commit eb3df53 into bentoml:main Dec 7, 2022
@aarnphm aarnphm deleted the chore/refactor-servicer-implementation branch December 7, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants