Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature: client.health #3315

Closed
aarnphm opened this issue Dec 5, 2022 · 4 comments · Fixed by #3636
Closed

feature: client.health #3315

aarnphm opened this issue Dec 5, 2022 · 4 comments · Fixed by #3636
Labels
good-first-issue Good for newcomers

Comments

@aarnphm
Copy link
Member

aarnphm commented Dec 5, 2022

Feature request

client to have a health function:

client.health()
await client.async_health()

Motivation

For HTTP, would probably just need to invoke /readyz, and for gRPC is to invoke the Health rpc from grpc.health.v1.HealthServicer.

Other

No response
@aarnphm aarnphm added the good-first-issue Good for newcomers label Dec 5, 2022
@sanspareilsmyn
Copy link

@aarnphm Hi! I'm a newbie to BentoML. May I work on this issue?

@aarnphm
Copy link
Member Author

aarnphm commented Dec 27, 2022

Hi there, feel free to pick up this issue after #3280 is merged.

@denyszhak
Copy link
Contributor

Has anyone started this one? It's being here for a while

@aarnphm
Copy link
Member Author

aarnphm commented Feb 28, 2023

feel free to pick it up. The client.health is already implemented for gRPC client. You can go a head and implement for HTTP client.

@denyszhak denyszhak mentioned this issue Mar 4, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good-first-issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore: http client healthcheck denyszhak/BentoML
3 participants
@aarnphm @denyszhak @sanspareilsmyn