Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: parsing path for env #3314

Merged
merged 1 commit into from Dec 6, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Dec 5, 2022

Parsing path for env field under docker

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

@aarnphm aarnphm requested a review from a team as a code owner December 5, 2022 17:14
@aarnphm aarnphm requested review from parano and removed request for a team December 5, 2022 17:14
@aarnphm aarnphm linked an issue Dec 5, 2022 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Dec 5, 2022

Codecov Report

Merging #3314 (77c2d64) into main (c91f83f) will decrease coverage by 0.00%.
The diff coverage is 14.28%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3314      +/-   ##
==========================================
- Coverage   33.74%   33.74%   -0.01%     
==========================================
  Files         108      108              
  Lines        9849     9853       +4     
  Branches     1696     1697       +1     
==========================================
+ Hits         3324     3325       +1     
- Misses       6296     6299       +3     
  Partials      229      229              
Impacted Files Coverage Δ
src/bentoml/_internal/bento/build_config.py 55.14% <14.28%> (-0.33%) ⬇️

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from larme December 5, 2022 19:00
@aarnphm aarnphm changed the title fix: parsing path for env feat: parsing path for env Dec 5, 2022
Copy link
Member

@larme larme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aarnphm aarnphm merged commit 687c3e0 into bentoml:main Dec 6, 2022
@aarnphm aarnphm deleted the fix/env-path-build-config branch December 6, 2022 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

bug: Docker env option does not support paths
2 participants