Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: from_sample override logic #3202

Merged
merged 3 commits into from Nov 9, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Nov 9, 2022

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner November 9, 2022 02:54
@aarnphm aarnphm requested review from jjmachan and sauyon and removed request for a team November 9, 2022 02:54
sauyon
sauyon previously approved these changes Nov 9, 2022
@codecov
Copy link

codecov bot commented Nov 9, 2022

Codecov Report

Merging #3202 (e0e1a8d) into main (bd092f2) will increase coverage by 10.74%.
The diff coverage is 53.40%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3202       +/-   ##
===========================================
+ Coverage   22.31%   33.06%   +10.74%     
===========================================
  Files          98       98               
  Lines        9300     9277       -23     
  Branches     1563     1585       +22     
===========================================
+ Hits         2075     3067      +992     
+ Misses       7182     5976     -1206     
- Partials       43      234      +191     
Impacted Files Coverage Δ
src/bentoml/_internal/service/openapi/__init__.py 95.83% <ø> (+27.08%) ⬆️
src/bentoml/_internal/io_descriptors/json.py 38.65% <18.51%> (+5.55%) ⬆️
src/bentoml/_internal/io_descriptors/image.py 38.98% <31.03%> (+8.66%) ⬆️
src/bentoml/_internal/io_descriptors/file.py 45.16% <43.47%> (+6.84%) ⬆️
src/bentoml/_internal/io_descriptors/text.py 68.42% <50.00%> (+9.59%) ⬆️
src/bentoml/_internal/io_descriptors/numpy.py 46.36% <53.33%> (+14.28%) ⬆️
src/bentoml/_internal/io_descriptors/pandas.py 42.95% <56.41%> (+14.13%) ⬆️
src/bentoml/_internal/io_descriptors/base.py 88.63% <100.00%> (+6.28%) ⬆️
src/bentoml/_internal/io_descriptors/multipart.py 58.33% <100.00%> (+13.75%) ⬆️
...bentoml/_internal/service/openapi/specification.py 92.92% <100.00%> (+2.35%) ⬆️
... and 48 more

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from sauyon November 9, 2022 03:15
@aarnphm aarnphm merged commit 248979b into bentoml:main Nov 9, 2022
@aarnphm aarnphm deleted the fix/from-sample branch November 9, 2022 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants