Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(runner): set uvicorn keep-alive #3198

Merged
merged 1 commit into from Nov 7, 2022
Merged

fix(runner): set uvicorn keep-alive #3198

merged 1 commit into from Nov 7, 2022

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Nov 7, 2022 •
edited

This mirrors the keep-alive we have set in our runner clients, which uvicorn does not appear to honor.

@sauyon sauyon requested a review from ssheng November 7, 2022 20:47
@sauyon sauyon requested a review from a team as a code owner November 7, 2022 20:47
@sauyon sauyon requested review from bojiang and removed request for a team November 7, 2022 20:47
@aarnphm aarnphm changed the title fix: set uvicorn keep-alive fix(runner): set uvicorn keep-alive Nov 7, 2022
@aarnphm aarnphm merged commit 22bd3f8 into bentoml:main Nov 7, 2022
@aarnphm aarnphm deleted the uvicorn_timeout branch November 7, 2022 22:15
@gusghrlrl101 gusghrlrl101 mentioned this pull request Apr 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aarnphm aarnphm aarnphm approved these changes

@ssheng ssheng Awaiting requested review from ssheng

@bojiang bojiang Awaiting requested review from bojiang bojiang is a code owner automatically assigned from bentoml/bentoml-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@sauyon @aarnphm