Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(sdk): separate default monitoring impl #3189

Merged
merged 1 commit into from Nov 4, 2022
Merged

Conversation

bojiang
Copy link
Member

@bojiang bojiang commented Nov 4, 2022

No description provided.

@bojiang bojiang marked this pull request as ready for review November 4, 2022 01:20
@bojiang bojiang requested a review from a team as a code owner November 4, 2022 01:20
@bojiang bojiang requested review from aarnphm and removed request for a team November 4, 2022 01:20
@bojiang bojiang changed the title refactor(sdk): seperate default implementation out refactor(sdk): separate default monitoring implementation out Nov 4, 2022
@codecov
Copy link

codecov bot commented Nov 4, 2022

Codecov Report

Merging #3189 (048735a) into main (0e8b7b8) will decrease coverage by 0.20%.
The diff coverage is 13.82%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3189      +/-   ##
==========================================
- Coverage   21.69%   21.48%   -0.21%     
==========================================
  Files         101      102       +1     
  Lines        9735     9764      +29     
  Branches     1691     1698       +7     
==========================================
- Hits         2112     2098      -14     
- Misses       7575     7619      +44     
+ Partials       48       47       -1     
Impacted Files Coverage Δ
src/bentoml/_internal/monitoring/default.py 0.00% <0.00%> (ø)
src/bentoml/_internal/server/http_app.py 0.00% <0.00%> (ø)
src/bentoml/_internal/monitoring/api.py 38.52% <25.00%> (-2.02%) ⬇️
src/bentoml/_internal/bento/build_config.py 33.69% <0.00%> (-0.38%) ⬇️
...bentoml/_internal/service/openapi/specification.py 90.56% <0.00%> (-0.05%) ⬇️
...c/bentoml/_internal/bento/build_dev_bentoml_whl.py 31.42% <0.00%> (+2.48%) ⬆️

@aarnphm aarnphm changed the title refactor(sdk): separate default monitoring implementation out refactor(sdk): separate default monitoring impl Nov 4, 2022
@aarnphm aarnphm merged commit a52a201 into bentoml:main Nov 4, 2022
@bojiang bojiang deleted the mon branch November 4, 2022 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants