Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: refine onnx implementation #3166

Merged
merged 5 commits into from Nov 8, 2022
Merged

Conversation

larme
Copy link
Member

@larme larme commented Oct 31, 2022

  • multiple outputs support
  • more detailed input type casting

What does this PR address?

Fixes #(issue)

Before submitting:

@larme larme requested a review from a team as a code owner October 31, 2022 20:42
@larme larme requested review from aarnphm and removed request for a team October 31, 2022 20:42
@larme larme marked this pull request as draft October 31, 2022 20:42
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #3166 (65ade2a) into main (22bd3f8) will decrease coverage by 0.17%.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3166      +/-   ##
==========================================
- Coverage   22.49%   22.31%   -0.18%     
==========================================
  Files          97       98       +1     
  Lines        9226     9300      +74     
  Branches     1550     1563      +13     
==========================================
  Hits         2075     2075              
- Misses       7108     7182      +74     
  Partials       43       43              
Impacted Files Coverage Δ
src/bentoml/_internal/frameworks/onnx.py 0.00% <0.00%> (ø)
src/bentoml/_internal/utils/onnx.py 0.00% <0.00%> (ø)

@larme
Copy link
Member Author

larme commented Oct 31, 2022

will add api v1 backward computability and more tests later

@larme larme marked this pull request as ready for review November 8, 2022 20:11
@aarnphm aarnphm changed the title refine onnx implementation perf: refine onnx implementation Nov 8, 2022
@aarnphm aarnphm merged commit bd092f2 into bentoml:main Nov 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants