Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: type checking hack #3162

Merged
merged 2 commits into from Oct 30, 2022
Merged

style: type checking hack #3162

merged 2 commits into from Oct 30, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Oct 30, 2022

A hack to conform with TYPE_CHECKING

Before
Screenshot 2022-10-29 at 20 07 36

After
Screenshot 2022-10-29 at 20 08 24

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner October 30, 2022 03:10
@aarnphm aarnphm requested review from sauyon and removed request for a team October 30, 2022 03:10
@codecov
Copy link

codecov bot commented Oct 30, 2022

Codecov Report

Merging #3162 (cbd0f44) into main (25c4b12) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3162   +/-   ##
=======================================
  Coverage   21.73%   21.73%           
=======================================
  Files         101      101           
  Lines        9710     9711    +1     
  Branches     1685     1685           
=======================================
+ Hits         2110     2111    +1     
  Misses       7552     7552           
  Partials       48       48           
Impacted Files Coverage Δ
src/bentoml/_internal/bento/build_config.py 34.07% <100.00%> (+0.18%) ⬆️

@sauyon
Copy link
Contributor

sauyon commented Oct 30, 2022

Let's call it ListStr at least

src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
src/bentoml/_internal/bento/build_config.py Outdated Show resolved Hide resolved
@aarnphm aarnphm changed the title style: hack around type checking style: type checking hack Oct 30, 2022
@aarnphm aarnphm merged commit 607cca2 into bentoml:main Oct 30, 2022
@aarnphm aarnphm deleted the style/type-checking branch October 30, 2022 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants