Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: framework ci #3157

Merged
merged 2 commits into from Oct 28, 2022
Merged

fix: framework ci #3157

merged 2 commits into from Oct 28, 2022

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Oct 28, 2022

fix broken fastai ci

Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm aarnphm requested a review from a team as a code owner October 28, 2022 19:01
@aarnphm aarnphm requested review from parano and removed request for a team October 28, 2022 19:01
@codecov
Copy link

codecov bot commented Oct 28, 2022

Codecov Report

Merging #3157 (f0ccade) into main (4220b51) will decrease coverage by 21.73%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main   #3157       +/-   ##
==========================================
- Coverage   21.73%   0.00%   -21.74%     
==========================================
  Files         101     101               
  Lines        9709    9708        -1     
  Branches     1683    1600       -83     
==========================================
- Hits         2110       0     -2110     
- Misses       7551    9661     +2110     
+ Partials       48      47        -1     
Impacted Files Coverage Δ
src/bentoml/grpc/utils/_import_hook.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/models/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/runner/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/service/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
src/bentoml/_internal/io_descriptors/__init__.py 0.00% <0.00%> (-100.00%) ⬇️
...bentoml/_internal/service/openapi/specification.py 0.00% <0.00%> (-90.62%) ⬇️
src/bentoml/_internal/utils/http.py 0.00% <0.00%> (-88.24%) ⬇️
src/bentoml/exceptions.py 0.00% <0.00%> (-87.50%) ⬇️
src/bentoml/_internal/io_descriptors/base.py 0.00% <0.00%> (-82.36%) ⬇️
...bentoml/_internal/runner/runner_handle/__init__.py 0.00% <0.00%> (-73.34%) ⬇️
... and 41 more

Copy link
Contributor

@sauyon sauyon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fine as a temporary fix

@aarnphm aarnphm merged commit d564519 into bentoml:main Oct 28, 2022
@aarnphm aarnphm deleted the fix-ci branch October 28, 2022 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants