Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async bento client methods #3152

Merged
merged 4 commits into from Oct 28, 2022
Merged

fix: async bento client methods #3152

merged 4 commits into from Oct 28, 2022

Conversation

sauyon
Copy link
Contributor

@sauyon sauyon commented Oct 27, 2022

Fixes the newly changed async/sync bento client methods, and makes from_url synchronous using the stdlib HTTPConnection so that it can be used in both async and non-async contexts.

@sauyon sauyon requested a review from a team as a code owner October 27, 2022 11:29
@sauyon sauyon requested review from jjmachan and aarnphm and removed request for a team October 27, 2022 11:29
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #3152 (8fdf5cc) into main (78d3e00) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3152   +/-   ##
=======================================
  Coverage   21.73%   21.73%           
=======================================
  Files         101      101           
  Lines        9709     9709           
  Branches     1683     1683           
=======================================
  Hits         2110     2110           
  Misses       7551     7551           
  Partials       48       48           

src/bentoml/client.py Outdated Show resolved Hide resolved
aarnphm
aarnphm previously approved these changes Oct 27, 2022
@aarnphm
Copy link
Member

aarnphm commented Oct 27, 2022

o the formatter check is failing @sauyon

@sauyon
Copy link
Contributor Author

sauyon commented Oct 27, 2022

Ah, you know what, my hooks all disappeared when I deleted my repo 😅

ssheng
ssheng previously approved these changes Oct 28, 2022
@ssheng ssheng merged commit 4220b51 into bentoml:main Oct 28, 2022
@aarnphm aarnphm deleted the client-fix branch October 28, 2022 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants