New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: async bento client methods #3152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sauyon
requested review from
jjmachan and
aarnphm
and removed request for
a team
October 27, 2022 11:29
Codecov Report
@@ Coverage Diff @@
## main #3152 +/- ##
=======================================
Coverage 21.73% 21.73%
=======================================
Files 101 101
Lines 9709 9709
Branches 1683 1683
=======================================
Hits 2110 2110
Misses 7551 7551
Partials 48 48 |
aarnphm
reviewed
Oct 27, 2022
aarnphm
previously approved these changes
Oct 27, 2022
o the formatter check is failing @sauyon |
Ah, you know what, my hooks all disappeared when I deleted my repo 😅 |
ssheng
reviewed
Oct 28, 2022
ssheng
previously approved these changes
Oct 28, 2022
ssheng
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the newly changed async/sync bento client methods, and makes from_url synchronous using the stdlib
HTTPConnection
so that it can be used in both async and non-async contexts.