Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: from_sample for IO descriptor #3143

Merged
merged 13 commits into from Nov 9, 2022
Merged

Conversation

aarnphm
Copy link
Member

@aarnphm aarnphm commented Oct 26, 2022

from_sample for all of our IO descriptor

@aarnphm aarnphm requested a review from a team as a code owner October 26, 2022 01:29
@aarnphm aarnphm requested review from parano and removed request for a team October 26, 2022 01:29
@codecov
Copy link

codecov bot commented Oct 26, 2022

Codecov Report

Merging #3143 (f2df17e) into main (22bd3f8) will increase coverage by 10.56%.
The diff coverage is 49.76%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #3143       +/-   ##
===========================================
+ Coverage   22.49%   33.05%   +10.56%     
===========================================
  Files          97       98        +1     
  Lines        9226     9314       +88     
  Branches     1550     1593       +43     
===========================================
+ Hits         2075     3079     +1004     
+ Misses       7108     5995     -1113     
- Partials       43      240      +197     
Impacted Files Coverage Δ
src/bentoml/_internal/service/openapi/__init__.py 95.83% <ø> (+27.08%) ⬆️
src/bentoml/_internal/io_descriptors/json.py 38.65% <18.51%> (+5.55%) ⬆️
src/bentoml/_internal/io_descriptors/image.py 39.20% <32.14%> (+8.88%) ⬆️
src/bentoml/_internal/io_descriptors/file.py 44.80% <41.66%> (+6.48%) ⬆️
src/bentoml/_internal/io_descriptors/numpy.py 45.94% <47.61%> (+13.86%) ⬆️
src/bentoml/_internal/io_descriptors/text.py 68.42% <50.00%> (+9.59%) ⬆️
src/bentoml/_internal/io_descriptors/pandas.py 42.63% <50.94%> (+13.81%) ⬆️
src/bentoml/_internal/io_descriptors/base.py 72.13% <69.23%> (-10.23%) ⬇️
src/bentoml/_internal/io_descriptors/multipart.py 58.33% <100.00%> (+13.75%) ⬆️
...bentoml/_internal/service/openapi/specification.py 92.92% <100.00%> (+2.35%) ⬆️
... and 50 more

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
depends on bentoml#3144 to be merged.

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
ssheng
ssheng previously approved these changes Nov 8, 2022
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@aarnphm
Copy link
Member Author

aarnphm commented Nov 8, 2022

TODO @aarnphm: e2e tests for from_sample

Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
@ssheng ssheng merged commit 39faf23 into bentoml:main Nov 9, 2022
@aarnphm aarnphm deleted the feat/from-sample branch November 9, 2022 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants