fix(prometheus): ensure metrics are lazily loaded #3089
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #3089 +/- ##
==========================================
- Coverage 21.73% 21.73% -0.01%
==========================================
Files 101 101
Lines 9709 9710 +1
Branches 1683 1685 +2
==========================================
Hits 2110 2110
- Misses 7551 7552 +1
Partials 48 48
|
aarnphm
force-pushed
the
chore/metrics
branch
3 times, most recently
from
e10e408
to
6555340
Compare
|
@aarnphm Why do we need this? |
|
When users use |
aarnphm
force-pushed
the
chore/metrics
branch
6 times, most recently
from
d95cca4
to
d565380
Compare
aarnphm
changed the title
aarnphm
force-pushed
the
chore/metrics
branch
from
7a05c8f
to
849851e
Compare
bojiang
reviewed
Oct 26, 2022
bojiang
reviewed
Oct 26, 2022
aarnphm
force-pushed
the
chore/metrics
branch
from
13d8d68
to
ed770b7
Compare
|
@aarnphm The test is still failling |
aarnphm
force-pushed
the
chore/metrics
branch
from
ecc5cf8
to
1d0017a
Compare
aarnphm
force-pushed
the
chore/metrics
branch
2 times, most recently
from
ec3839d
to
1a9bbe7
Compare
|
It seems the e2e tests are skipped. Let's continue the review when it's enabled |
aarnphm
force-pushed
the
chore/metrics
branch
2 times, most recently
from
5da119a
to
484d32e
Compare
aarnphm
force-pushed
the
chore/metrics
branch
2 times, most recently
from
aaba4c2
to
ee4ff3c
Compare
sauyon
reviewed
Oct 28, 2022
aarnphm
force-pushed
the
chore/metrics
branch
from
ad1573f
to
abf3911
Compare
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
Co-authored-by: Sauyon Lee <2347889+sauyon@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
Signed-off-by: Aaron Pham <29749331+aarnphm@users.noreply.github.com>
aarnphm
force-pushed
the
chore/metrics
branch
from
981d789
to
75fce2b
Compare
sauyon
approved these changes
Oct 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR address the issue inside the container, where if the user service uses
bentoml.metrics, the service is imported beforePROMETHEUS_MULTIPROC_DIRis created.Signed-off-by: Aaron Pham 29749331+aarnphm@users.noreply.github.com