Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configuration: migrate schema to api_server #3046

Merged
merged 1 commit into from Sep 27, 2022

Conversation

ssheng
Copy link
Collaborator

@ssheng ssheng commented Sep 27, 2022

What does this PR address?

Move access logging format configuration from a top level config to under api_server.logging.access for semantic correctness.

Before submitting:

@ssheng ssheng requested a review from a team as a code owner September 27, 2022 21:10
@ssheng ssheng requested review from jjmachan and removed request for a team September 27, 2022 21:10
@codecov
Copy link

codecov bot commented Sep 27, 2022

Codecov Report

Merging #3046 (208ce99) into main (76ade96) will decrease coverage by 1.11%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3046      +/-   ##
==========================================
- Coverage   62.33%   61.22%   -1.12%     
==========================================
  Files         132      132              
  Lines       11522    11522              
  Branches     1923     1923              
==========================================
- Hits         7182     7054     -128     
- Misses       3905     4035     +130     
+ Partials      435      433       -2     
Impacted Files Coverage Δ
bentoml/_internal/configuration/containers.py 69.29% <ø> (ø)
bentoml/_internal/log.py 79.68% <100.00%> (ø)
bentoml/_internal/frameworks/torchscript.py 0.00% <0.00%> (-92.00%) ⬇️
bentoml/_internal/frameworks/common/pytorch.py 0.00% <0.00%> (-69.48%) ⬇️
bentoml/_internal/runner/strategy.py 76.27% <0.00%> (-10.17%) ⬇️
bentoml/_internal/runner/runner_handle/local.py 76.00% <0.00%> (-4.00%) ⬇️
bentoml/_internal/utils/lazy_loader.py 76.47% <0.00%> (-2.95%) ⬇️
bentoml/_internal/models/model.py 83.44% <0.00%> (-1.99%) ⬇️
bentoml/_internal/runner/runner.py 83.63% <0.00%> (-1.82%) ⬇️

@ssheng ssheng changed the title chore: Update access log format configuration schema. chore: Update access log format configuration schema Sep 27, 2022
@aarnphm aarnphm changed the title chore: Update access log format configuration schema configuration: migrate schema to api_server Sep 27, 2022
@aarnphm aarnphm merged commit c8e5587 into bentoml:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants